Issue 14889 & 14900 & [REG2.068.0] 14911 - Reimplement fix for issue 1215 #4876
Conversation
|
I've just started working yesterday for issue 14889, so this change would have some risk (in particular the refactoring in @MartinNowak and @WalterBright How do you think about issue 14900? |
Let's change the changelog for now and then we'll see how to complete the feature. |
9rnsr
force-pushed
the
fix14889
branch
2 times, most recently
from
9184736
to
b01b687
Compare
|
OK, I removed excessive refactoring in |
Make TypeIdentifier::toDsymbol consistent with TypeInstance::toDsymbol
Fix incomplete parser for statement scope declarations.
9rnsr
changed the title
|
I append one more commit for the the 2.068 regression 14911. It's a workaround for the parser. |
|
Not able to pull/review, but shouldn't this target stable? |
|
I don't know. master branch will be converted to ddmd, so I'm not sure the stable branch will be released. |
|
It's a good question, @MartinNowak what happens to stable when ddmd is applied to the master? It seems like we will have to have at least one release where stable changes must target both master and stable, one in C++, one in D. |
|
stable changes should still only address the stable branch, i.e. they'll be written in C++. |
Yes, the stable branch will be used for 2.068.1 in about 3 weeks. |
|
LGTM, though it's a pretty big change for this tiny feature. |
|
@MartinNowak See #4918. |
Issue 14889 - ICE: Assertion `o->dyncast() == DYNCAST_DSYMBOL' failed.
Issue 14900 - 2.068.0 change log example does not compile
Issue 14911 - Compiler found indexing in code "new MyStruct[2].ptr"
It was implemented in #4516, but unfortunately the we didn't get enough chance to test the new feature.