Issue 14621, 14624, 14625 - Fix bugs in array operator overloading semantics #4948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9rnsr
force-pushed
the
fix14621
branch
2 times, most recently
from
290e951
to
53f3df0
Compare
…ng fallback Points: - Shorten the length of problematic gagged semantic path. - Improve ArrayExp as the entry point of array operator overloading. - Reduce stack size and the number of heap-allocated AST nodes for recursive semantic analysis. Also fixes unlisted wrong-code issue. See test20x() in runnable/opover2.d
…bal.errors' on line 752 in file 'statement.c'
|
I fixed ddmd build failure in Win32/64. |
|
All green. |
|
LGTM, I'll have to merge stable into master before pulling, or I'll have to deal with too many conflicts at once. |
|
Auto-merge toggled on |
|
Thanks. |
MartinNowak
added a commit
that referenced
this pull request
Aug 29, 2015
Issue 14621, 14624, 14625 - Fix bugs in array operator overloading semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is same with #4686, excepting the base branch is 'stable'.
Issue 14621 - [REG2.066] ICE: Assertion failure: 'global.gaggedErrors || global.errors' on line 752 in file 'statement.c'
Issue 14624 - The array operator overloading fallback is not correct
Issue 14625 - opIndex() doesn't work on foreach container iteration
Shorten the length of gagged semantic path, and improve
ArrayExpas the entry point of array operator overloading.