Issue 13702 - One missed 'may cause GC allocation' error message #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1791,13 +1791,14 @@ public: | |||
| fbody = new CompoundStatement(Loc(), fbody, s); | |||
| } | |||
| } | |||
| if (returns && !fbody.isErrorStatement()) | |||
| if (returns) | |||
There was a problem hiding this comment.
Do we pay for the extra checks with slightly less performance in case this is done during speculative evaluations? Maybe just produce the complete @nogc coverage when not gagged.
There was a problem hiding this comment.
Sorry for late reply. I think, we should have same semantic analysis behavior with/without gagging. Branching analysis process depending on global.gag would be a cause of bug.
|
9rnsr
force-pushed
the
fix13702
branch
2 times, most recently
from
61d3492
to
8506d6b
Compare
|
This is a 2.066 regression! |
|
Auto-merge toggled on |
ibuclaw
added a commit
that referenced
this pull request
Feb 2, 2016
Issue 13702 - One missed 'may cause GC allocation' error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=13702