Remove dead code and deprecated syntax #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to toggle auto-merge on as soon as the tester has caught up to this. |
|
Thanks, will do. |
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Sep 17, 2015
Remove dead code and deprecated syntax
|
This PR introduced a regression: |
|
Just from looking at the diff, I suspect it's caused by the change in dtemplate.d. |
| @@ -1688,7 +1688,7 @@ public: | |||
| default: | |||
| goto Lnomatch; | |||
| } | |||
| ++argi; | |||
| assert(0); | |||
There was a problem hiding this comment.
this change looks suspicious
There was a problem hiding this comment.
If it's wrong then there's a compiler bug in dead code detection.
There was a problem hiding this comment.
The easiest way to find out what caused the regression is to back all these changes out, then add them one by one until the regression happens.
|
This PR looks good (and reverting it doesn't fix the issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.