New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dcast.d #5197
Cleanup dcast.d #5197
Conversation
This front-end cleanup is necessary for: |
What are you (re-)aligning the comments to? I don't see the point of this when the comments aren't on consecutive lines. Some of these changes (like moving that function) seem to have very little benefit. |
@yebblies As I commented in commit log, the |
333da93
to
c59f883
Compare
This is ok with me, except for the repositioning of AddrExp.castTo. That one is just churn. I understand that you wish to move it nearer where it is used, but if we continue down that route the whole source code base will be upended, and my usual nightmare of making it impossible to compare code from one release to the next will be realized. When doing refactorings, please please keep in mind the affect on diffs. |
Diff? It's not a matter today. When we release a dmd version, we'll forget its previous versions. The maintained release versions and development versions are managed in two distinct breanches ( Ultimately I believe program source code should have no meaningless matters. In this case, Why we keep code format style? Because consistent style will help to focus on the code logic. Why I recommend to reorder Indeed, it's a little artistic sense. However, I think and believe that making code more meaningfulness will increase code readability and maintainability. |
3f1bf84
to
4b90faa
Compare
Removed line space changes and repositioning. |
`castTo` should not modity `e.type` by the `toBasetype()` result. Also, `implicitConvTo` should not modify `ImplicitConvTo.t` by the `toBasetype()` result.
Ping to @yebblies and @WalterBright . |
Auto-merge toggled on |
@yebblies Thanks! |
No description provided.