[REG2.069.0-b1] Issue 15207 - Wrong codegen with -inline #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Too squashed code blocks hard to understand. - Too long condition lines are hard to read.
When issue 14944 fixed, the ref variable content initializing form had been flagged by `MemorySet.refValueInit`. However, inilining may replace `AssignExp.e1` operand with a `STCref` temporary variable. When it happens, the `MemorySet.refValueInit` flag will be ignored in `AssignExp.toElem` and wrong code had generated. To avoid the issue, instead flag the case "ref varaible initialization" by `MemorySet.referenceInit`. Its meaning will be kept beyond inlining stage, and the bug won't happen.
After this change, the frontend code for internal code generation would be simple: - If value assignment (construction) may need postblit call, use `ConstructExp`. - If bare memory copy is necessary, use `BlitExp`.
A referernce variable initialization is not normally generated from source code. It's always introduced by internal AST generation or inlining. So, the ref variables handling is necessary only when the new convenient constructos used for them.
9rnsr
changed the title
9rnsr
changed the title
|
Looks good. |
MartinNowak
added a commit
that referenced
this pull request
Oct 21, 2015
[REG2.069.0-b1] Issue 15207 - Wrong codegen with -inline
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=15207
When issue 14944 fixed, the ref variable content initializing form had been flagged by
MemorySet.refValueInit.However, inilining may replace
AssignExp.e1operand with aSTCreftemporary variable.When it happens, the
MemorySet.refValueInitflag will be ignored inAssignExp.toElemand wrong code had generated.To avoid the issue, instead flag the case "ref varaible initialization" by
MemorySet.referenceInit.Its meaning will be kept beyond inlining stage, and the bug won't happen.