[REG2.069] Issue 15296 - cannot inline simple function that calls use non-inlinable statements #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
9rnsr
force-pushed
the
fix15296
branch
2 times, most recently
from
4e6a915
to
d167f32
Compare
| { | ||
| CallExp ce = cast(CallExp)s.exp; | ||
| if (ce.e1.op == TOKvar) // workaround for Bugzilla 15296 | ||
| visitCallExp(ce, null, true); |
There was a problem hiding this comment.
How does restricting the inlining to a specific case help to fix an issue where something is not inlined?
Also visitCallExp already handles TOKvar as first branch (see here).
The comment isn't useful either b/c the bugzilla page doesn't contain any information other than the bug report. Please don't introduce obscure special cases w/o any explanation at all.
There was a problem hiding this comment.
OK, I added more detailed comment.
As I wrote, the essential problem is a inlineScan call in a few lines before. First I tried to fix it, but it was not possible quickly.
…linable statements Add workaround to do inlining same with the old code.
MartinNowak
added a commit
that referenced
this pull request
Nov 21, 2015
[REG2.069] Issue 15296 - cannot inline simple function that calls use non-inlinable statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=15296