Issue 3733 - Overloading on 'this' modifiers fails with implicit 'this' #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, please merge. |
|
Rebased. |
yebblies
added a commit
that referenced
this pull request
Oct 7, 2012
Issue 3733 - Overloading on 'this' modifiers fails with implicit 'this'
Now github can predict the future... worrying. |
|
hehe... guess there's some clock skew in there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4392 and 3733 are similar, but are bit different.
Issue 4392 - Problems with const/non-const overloads of member functions
In
CallExp::semanticwithe1->op == TOKvar, the head of overloads is unintentionally changed.Issue 3733 - Overloading on 'this' modifiers fails with implicit 'this'
Between shared and non-shared overloading,
FuncDeclaration::overloadResolvecannot determine the actual callee ifethisisNULL. In this case we should defer the resolution until after adding 'this'