more const in root #5409
Merged
more const in root #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,7 +73,7 @@ struct File | |||
| size_t size; | |||
| stat_t buf; | |||
| ssize_t numread; | |||
| char* name = this.name.toChars(); | |||
| const(char)* name = this.name.toChars(); | |||
There was a problem hiding this comment.
I thought about that, and decided explicit was better when doing this conversion.
There was a problem hiding this comment.
That will mean we're going to have to go back and change them all again when toChars starts returning string
There was a problem hiding this comment.
It'll all have to be scrutinized line by line anyway, because of 0 termination, rewrite to toString, etc. It's not encapsulated well at all.
WalterBright
force-pushed
the
constFile
branch
from
f198888
to
f98d784
Compare
| @@ -40,7 +40,7 @@ struct File | |||
| _ref = 0; | |||
| buffer = null; | |||
| len = 0; | |||
| name = cast(FileName*)n; | |||
| name = n; | |||
There was a problem hiding this comment.
@yebblies here's an example of as const use grows, the casts can be removed.
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.