Fix issue 1357 - permit \uFFFE and \uFFFF codepoints #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -22,9 +22,6 @@ bool utf_isValidDchar(dchar c) | |||
| // surrogate pairs | |||
| if (0xD800 <= c && c <= 0xDFFF) | |||
| return false; | |||
| // non-characters | |||
There was a problem hiding this comment.
I'd like to see a comment here saying specifically that FFFE and FFFF are allowed for internal use, so the next maintainer won't 'fix' it back again. A link to the discussion https://issues.dlang.org/show_bug.cgi?id=1357 would be helpful as well.
DmitryOlshansky
force-pushed
the
issue-1357
branch
from
23ac6f3
to
c3991c4
Compare
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like phobos does. There is no need to disallow them they are internal use but valid regardless.