-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP1: Implement SDL package description support #582
Conversation
Wiki page is updated now. |
Since this is an additive change and all tests pass, I'd just merge this as it is. Does anyone want to have a look first? The actual change set is not as big as it looks. The "sdlang-d" commit can just be ignored for the review. It would also be interesting to review the SDL based format to see if there is anything that could be optimized in terms of usability (see the DEP link at the top). |
Just testing it out on my local branch now.
It fails to parse it, throwing an unhelpful error:
It would be good to add a some debug info here for the user to understand whats going wrong.
Here is the dub.sdl that will build dub:
My suggestion though would be to add an error something along the lines of: |
The error checking code was still missing. Now outputs something along the lines of:
|
Yeah, it's much better/easier to use when the error checking is in there! Looks good! |
Merging to master. @grogancolin Thanks for the review! |
DEP1: Implement SDL package description support
This implements DEP1 with a few fields added that are still absent from the wiki page.