Skip to content

Commit

Permalink
Embed only the "dmd2" folder, not its parent
Browse files Browse the repository at this point in the history
  • Loading branch information
brad-anderson committed Jul 27, 2014
1 parent e944775 commit d2c01d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion create_dmd_release/build_all.d
Expand Up @@ -300,7 +300,7 @@ void runBuild(Box box, string gitTag, bool combine)
sh = box.shell();
sh.stdin.writeln(`cd clones\installer\windows`);
sh.stdin.writeln(`&'C:\Program Files (x86)\NSIS\makensis'`~
` '/DEmbedD2Dir=C:\Users\vagrant\dmd.`~gitTag~`.windows'`~
` '/DEmbedD2Dir=C:\Users\vagrant\dmd.`~gitTag~`.windows\dmd2'`~
` '/DVersion2=`~ver~`' d2-installer.nsi`);
sh.stdin.writeln(`copy dmd-`~ver~`.exe C:\Users\vagrant\dmd-`~ver~`.exe`);
sh.close();
Expand Down

3 comments on commit d2c01d7

@brad-anderson
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'm used to using the online editor on Github to make pull requests but since I'm a committer on this repo it just edited the repo directly.

@brad-anderson
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted by 8ed9a9b. I hope this didn't inconvenience anyone. A proper pull request will follow.

@MartinNowak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a common pitfall, someone should talk github into making this more obvious.

Please sign in to comment.