Embed "dmd2" folder, not its parent #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to be cherry picked into the 2.066 branch prior to 2.066 release. (ping @AndrewEdwards). Also, please forgive me for accidentally making d2c01d7 and its revert 8ed9a9b. Github's online editor doesn't make a pull request when you are a committer apparently. |
AndrewEdwards
added a commit
that referenced
this pull request
Jul 27, 2014
Embed "dmd2" folder, not its parent
|
Thanks, great to have the files embedded finally. |
AndrewEdwards
added a commit
that referenced
this pull request
Jul 28, 2014
Embed "dmd2" folder, not its parent
|
Yeah, it's pretty slow. Now that we aren't including the files for every platform it's actually rather small already. I'll try out removing |
Thanks, it's not of utmost importance though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beta installer was putting everything in
C:\D\dmd.v2.066.0-b6.windowsrather thanC:\D.