-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize new API, more examples #1470
Conversation
this()(R input, uint groups, NamedGroup[] named) | ||
{ | ||
_input = input; | ||
ngroup = groups; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer members to start with _
. That way incidentally make constructor writing easily because you can use the same name (without underscore) for parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That way incidentally make constructor writing easily
... and everything else uglier. I'm still divided on this matter (as camn be seen in the source code, heh).
Anyway I'll make this struct consistently underscorish.
fix the nits and let's get this in |
Also fix issue 9579.
Done |
Finalize new API, more examples
Perfect. |
@blackwhale, |
@denis-sh Good catch, will do. |
The procedure is:
So now we're at #1. Once we have a beta I'll begin working on the next changelog and I'll ping you for a description of this changeset. |
@blackwhale: If you can you could ping me with the examples of the API so I can put them in the changelog. |
The core part of pull #1225.
This neatly fixes issue 7260.
Basically everyone (me included) forgets to set the global flag in a regex foreach.
Coupled with the fact that
splitter
already cracks open regex to set global flag it's painfully obvious that global/local is an attribute of operation but not of the pattern itself.Hence separate API calls, plus I use the opportunity to simplify the single match case to just get a range of submatches.
Also fixes issue 9579.