Fix for Bug #6472. Make RedBlackTree's removeKey work with strings. #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to have non final containers with final methods. It will make them inlineable and open to augmentation. |
andralex
added a commit
that referenced
this pull request
Feb 5, 2012
Fix for Bug #6472. Make RedBlackTree's removeKey work with strings.
marler8997
pushed a commit
to marler8997/phobos
that referenced
this pull request
Nov 10, 2019
Bump libdparse to 0.10.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=6472
I also made
RedBlackTreefinal, which it should have been in the first place. That might break code (if anyone decided to derive their own class fromRedBlackTree- unlikely IMHO), but it was already decide previously that std.container's containers should be final classes so that they would be reference types and still be able to have their functions be non-virtual and inlinable.