Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] quartz sound must be table not just string of the file, for neweer engines #45

Closed
hacknorris-code opened this issue Jun 21, 2022 · 2 comments
Closed

[bug] quartz sound must be table not just string of the file, for neweer engines #45

hacknorris-code opened this issue Jun 21, 2022 · 2 comments
Labels
bug enhancement

Comments

@hacknorris-code
Copy link

bug :

Przechwycenie obrazu ekranu_2022-06-21_18-55-59

o.O

debug.txt
@mckaygerhard
Copy link
Collaborator

mckaygerhard commented Jun 21, 2022 •
edited
Loading

the 5.5 changes a lot the api.. poikilos already talk about the constants changes at https://poikilos.org/2020/05/09/minetest-scope-issue/ i am able to run "LOM" until 5.2 only... for 5.4 and 5.5 some time will pass.. i currently study the defaults mod changes to provide backported changes..

.. so about the error quarzt .. a mineral.. at register_slab("quartzstair", "quartz:pillar", sound must be a table since 5.4 as https://github.com/minetest/minetest/blob/5.4.0/doc/lua_api.txt#L7270 . so fix are just a "{" and "}" around.. but i will do not that yet.. as i explained previously cos i will maintain blackguard compatibility..

2022-06-21 18:55:50: ERROR[Main]: ...me\minetest-5.5.1-win64\bin\..\builtin\game\register.lua:184: bad argument #5 to 'register_item_raw' (table expected, got string)

but noted that E:\game\minetest-5.5.1-win64 i do not officially support guindows.. so i will test only for linux .. noted you run xfce4 maybe you runs minetest 5.5 emulated but there's some packages in OBS build service... so for valids bug i will only fix linux debugs..

marked as bug cos are valid but fix will be not so yet .. cos already works in 5.2

@mckaygerhard mckaygerhard changed the title can not open [bug] quartz sound must be table not just string of the file, for neweer engines Jun 21, 2022
@mckaygerhard mckaygerhard mentioned this issue Jun 21, 2022
Open
mckaygerhard added a commit to minenux/minetest-game-LegendofMinetest that referenced this issue Jun 21, 2022
@mckaygerhard
improve sound in registration node.. due the changes in minetest engi…
60036b8 
…ne api

* for backguard compatibility must follow https://codeberg.org/minenux/minenux/issues/19
* fix D00Med#45
@mckaygerhard mckaygerhard mentioned this issue Jun 21, 2022
Merged
@hacknorris-code
Copy link
Author

ok.
yes i "emulated" USING W.I.N.E. lool

mckaygerhard added a commit to minenux/minetest-game-LegendofMinetest that referenced this issue Jul 21, 2022
@mckaygerhard
Merge PR from minenux/bugfixeds-quartz-sounds-new-api fixed soudn issues
f8f823d 
* due lack of feedback i'll assume this works.. so merge this and close issue D00Med#45
* Close D00Med#45 by D00Med#46
* for backguard compatibility must follow https://codeberg.org/minenux/minenux/issues/19 this guide must be used to detect the engine version and property put changes
* First commit include fix for D00Med#45 the explanation is on the issue
mckaygerhard added a commit to minenux/minetest-game-LegendofMinetest that referenced this issue Jul 21, 2022
@mckaygerhard
fix previous commit "Fix detection of engine.." about sound changes
a0fb494 
* fix commit 60036b8
* fix commit 62728e8
* forgotten the namespace global "minetest" for "has_feature"
* really closes D00Med#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mckaygerhard @hacknorris-code