Clean up small TODO

DA0-DA0 · Jan 9, 2024 · 617fba4 · 617fba4
1 parent 208244f
commit 617fba4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/contracts/external/cw-abc/src/commands.rs b/contracts/external/cw-abc/src/commands.rs
@@ -262,10 +262,10 @@ fn calculate_exit_fee(
         CommonsPhase::Closed => return Ok(Uint128::zero()),
     };
 
-    // TODO more normal check?
-    debug_assert!(
+    // Ensure the exit fee is not greater than 100%
+    ensure!(
         exit_fee <= StdDecimal::percent(100),
-        "Exit tax must be <= 100%"
+        ContractError::InvalidExitFee {}
     );
 
     // This won't ever overflow because it's checked

diff --git a/contracts/external/cw-abc/src/error.rs b/contracts/external/cw-abc/src/error.rs
@@ -28,6 +28,9 @@ pub enum ContractError {
     #[error("Hatch phase config error {0}")]
     HatchPhaseConfigError(String),
 
+    #[error("Invalid exit fee, must be less than 100%.")]
+    InvalidExitFee {},
+
     #[error("Invalid subdenom: {subdenom:?}")]
     InvalidSubdenom { subdenom: String },