Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial phase integration to cw-abc #698

Merged
merged 11 commits into from
Apr 23, 2023
Merged

Initial phase integration to cw-abc #698

merged 11 commits into from
Apr 23, 2023

Conversation

adairrr
Copy link

@adairrr adairrr commented Apr 22, 2023 •
edited

This change does the following:

  • initial phase configuration setup for cw-abc
  • phase configurations and current phase stored in state
  • Hatch phase has an allowlist
  • Basic phase queries
  • cw-ownable integration
  • Move queries & commands to queries and commands respectively
  • Addition of funding pool to the curve state

There are TODOs where functionality is still missing. The burn mechanism was left untouched.

Questions:

  1. Do we want to have a PreHatch phase where the configuration can be changed freely? Hatch configuration for the initialPrice should NOT be changed after the phase has begun, though the min and max initialRaise should be able to be changed (like in traditional fundraising)
  2. Do we want to separate the phase configurations into their own states so that there's not unnecessary loading of state?
  3. Closed phase? Necessary?
  4. Testing - BOOT will be updated to work with custom messages shortly, so should be able to integrate soon.

JakeHartnell
JakeHartnell approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this direction! ❤️

@JakeHartnell JakeHartnell merged commit 1ac45a7 into DA0-DA0:cw-abc Apr 23, 2023
1 of 3 checks passed
@adairrr adairrr deleted the cw-abc branch April 23, 2023 16:38
JakeHartnell pushed a commit that referenced this pull request Jul 9, 2023
@adairrr @JakeHartnell
Initial phase integration to cw-abc (#698)
ba016ba 
* CwAbcResult

* Hatch phase configuration and init msg refactor

* Initial instantiate test

* Implement separate phrases and phrase configs

* Remove vesting phase and update funding pool

* Separate commands and queries

* Update init msg with string configs

* Phase config query

* MinMax and config query

* Add some todos

* cw-ownable integration
JakeHartnell pushed a commit that referenced this pull request Aug 31, 2023
@adairrr @JakeHartnell
Initial phase integration to cw-abc (#698)
3d2a61c 
* CwAbcResult

* Hatch phase configuration and init msg refactor

* Initial instantiate test

* Implement separate phrases and phrase configs

* Remove vesting phase and update funding pool

* Separate commands and queries

* Update init msg with string configs

* Phase config query

* MinMax and config query

* Add some todos

* cw-ownable integration
JakeHartnell pushed a commit that referenced this pull request Oct 30, 2023
@adairrr @JakeHartnell
Initial phase integration to cw-abc (#698)
f88c365 
* CwAbcResult

* Hatch phase configuration and init msg refactor

* Initial instantiate test

* Implement separate phrases and phrase configs

* Remove vesting phase and update funding pool

* Separate commands and queries

* Update init msg with string configs

* Phase config query

* MinMax and config query

* Add some todos

* cw-ownable integration
JakeHartnell pushed a commit that referenced this pull request Dec 5, 2023
@adairrr @JakeHartnell
Initial phase integration to cw-abc (#698)
af98c63 
* CwAbcResult

* Hatch phase configuration and init msg refactor

* Initial instantiate test

* Implement separate phrases and phrase configs

* Remove vesting phase and update funding pool

* Separate commands and queries

* Update init msg with string configs

* Phase config query

* MinMax and config query

* Add some todos

* cw-ownable integration
JakeHartnell pushed a commit that referenced this pull request Dec 23, 2023
@adairrr @JakeHartnell
Initial phase integration to cw-abc (#698)
f0bdfc4 
* CwAbcResult

* Hatch phase configuration and init msg refactor

* Initial instantiate test

* Implement separate phrases and phrase configs

* Remove vesting phase and update funding pool

* Separate commands and queries

* Update init msg with string configs

* Phase config query

* MinMax and config query

* Add some todos

* cw-ownable integration
JakeHartnell pushed a commit that referenced this pull request Jan 8, 2024
@adairrr @JakeHartnell
Initial phase integration to cw-abc (#698)
5a6120c 
* CwAbcResult

* Hatch phase configuration and init msg refactor

* Initial instantiate test

* Implement separate phrases and phrase configs

* Remove vesting phase and update funding pool

* Separate commands and queries

* Update init msg with string configs

* Phase config query

* MinMax and config query

* Add some todos

* cw-ownable integration
JakeHartnell pushed a commit that referenced this pull request Mar 26, 2024
@adairrr
Initial phase integration to cw-abc (#698)
aceb8ba 
* CwAbcResult

* Hatch phase configuration and init msg refactor

* Initial instantiate test

* Implement separate phrases and phrase configs

* Remove vesting phase and update funding pool

* Separate commands and queries

* Update init msg with string configs

* Phase config query

* MinMax and config query

* Add some todos

* cw-ownable integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeHartnell JakeHartnell JakeHartnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adairrr @JakeHartnell