Staking UI #128
Staking UI #128
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/da0da0/dao-dao/CRUivbphAbahpXdnM1hzBWevnaEj |
JakeHartnell
force-pushed
the
staking-ui
branch
from
18d6df0
to
cd27716
Compare
JakeHartnell
force-pushed
the
staking-ui
branch
from
cd27716
to
44391c8
Compare
| <div className="card bordered shadow-lg card-side m-2 inline-flex"> | ||
| <div className="card-body py-6"> | ||
| <h2 className="card-title"> | ||
| {title} <HelpTooltip text={tooltip} /> |
There was a problem hiding this comment.
There is sadly an issue with card and HelpTooltip where the message gets hidden. I tried to work around it a little a while ago but didn't have much success. Maybe we could just move this info to some text on the page for now?
There was a problem hiding this comment.
Fixed! You have to make sure the card or container has overflow-visible
| stake, | ||
| stakedBalance, | ||
| unstake, | ||
| } = useStaking(daoInfo?.gov_token as string) |
There was a problem hiding this comment.
Playing around with this it seems like staking / unstaking won't trigger this state to be updated. I don't think this is something that needs to block the PR but something to note. Not even sure how you'd tell react that pressing that button should cause this hook to be re run..
There was a problem hiding this comment.
Perhaps @ebaker or @gavindoughtie would know how to do that?
There was a problem hiding this comment.
I thought about this too... it's not ideal and I don't expect it to last long.
Why I think we should ship this now:
- Will soon have lots of examples and patterns for using recoil (can just wait until those are ready)
- Allows us to update the contracts on Juno Testnet (which are out of date and lead to some frontend bugs)
- Sidebar / 3 column layout is coming... really want some of this to potentially live there
Ideally, when you're visiting a DAO, it shows how many DAO tokens you have and how many are staked in the third column.
There was a problem hiding this comment.
Great , am also looking forward to learning more about recoil to hopefully fix these kinds of issues :)
Adds UI for staking gov tokens. This is needed to support the newest version of the DAO contracts.