-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gas limit to voice message execution and ACK on out-of-gas. #22
Conversation
This adds a manually tuned gas limit to voice packet handling so that even if the packet causes an out-of-gas error, the module reserves enough gas to return an ACK informing the caller of the out-of-gas error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This is blocked on two things:
|
@Art3miX - lmk what you think of this. i reorganized the tests, set up CI, found a bug, and made some progress reproducing the handshake bug in interchaintest so i'm now pretty sure that's a problem with IBC and not with our handshake process. |
now blocked on more SDK quirks:tm: cosmos/ibc-go#3428 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome as always, few small nits
Co-authored-by: Art3miX <40179351+Art3miX@users.noreply.github.com>
Co-authored-by: Art3miX <40179351+Art3miX@users.noreply.github.com>
This adds a manually tuned gas limit to voice packet handling so that even if the packet causes an out-of-gas error, the module reserves enough gas to return an ACK informing the caller of the out-of-gas error.