create links key at node level in registry #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
reviewed
Jul 10, 2023
dchandan
reviewed
Jul 12, 2023
README.md
Outdated
| | `cite-as` <br> `publication` | Attribution by researchers to reference the node when using it for publications | | | ||
| | `copyright` <br> `license` <br> `terms-of-service` | Legal use of the node | | | ||
| | `describedby` | URL to full documentation and details of the node, its purpose and so on | | | ||
| | `edit` | A self-reference to https://github.com/DACCS-Climate/DACCS-node-registry or anywhere that the specific node registry entry to redirect users where to update it | | |
There was a problem hiding this comment.
I'm not sure I follow the wording of this entry.
There was a problem hiding this comment.
Yeah, I'll do a little proofread/edit and make the wording a bit more consistent
node_registry.json
Outdated
There was a problem hiding this comment.
Do we need the node_registry.json file in this branch anymore?
There was a problem hiding this comment.
Yes we do. The node_registry.json in this file contains the static information and should be edited by node managers. The version in the current-registry branch has a superset of that info that includes all the data grabbed daily from the node endpoints and some additional metadata.
fmigneault
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #10, this does the following:
linkskey for each nodeurlkey with an entry inlinks(rel=service)icon_urlkey with an entry inlinks(rel=icon)rel=versionentry inlinks(refers to the/versionendpoint)rel=collectionentry inlinks(refers the the/servicesendpoint)Resolves #10