Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collapse all feature #149

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Add collapse all feature #149

merged 3 commits into from
Apr 8, 2024

Conversation

elijahbenizzy
Copy link
Contributor

@elijahbenizzy elijahbenizzy commented Apr 8, 2024 •
edited
Loading

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Copy link
Contributor

skrawcz commented Apr 8, 2024

you need to rebase this branch?

@skrawcz
Copy link
Contributor

skrawcz commented Apr 8, 2024

seeing the JSON state is broken for me on this branch.

@elijahbenizzy
Adds expand-all/contract-all buttons
ac45710 
This allows us to fully collapse sections but leave the sub-sections
there for the result/data view. In JSON view we just collapse it all.

See #148
@elijahbenizzy
Copy link
Contributor Author

seeing the JSON state is broken for me on this branch.

Seems to work with mine. Rebased as well, perhaps that fixed it.

@elijahbenizzy elijahbenizzy enabled auto-merge (rebase) April 8, 2024 21:46
@elijahbenizzy elijahbenizzy mentioned this pull request Apr 8, 2024
Closed
skrawcz
skrawcz approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the fixes this LGTM.

@elijahbenizzy elijahbenizzy merged commit 20b22e0 into main Apr 8, 2024
8 checks passed
@elijahbenizzy elijahbenizzy deleted the add-collapse-all branch April 8, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elijahbenizzy @skrawcz