Forking/parallelism tracking #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
changed the title
elijahbenizzy
force-pushed
the
spawn-applications
branch
from
83cf88a
to
3c81688
Compare
|
Also fixes #211 |
elijahbenizzy
force-pushed
the
spawn-applications
branch
2 times, most recently
from
cacb9c3
to
467f484
Compare
elijahbenizzy
commented
May 31, 2024
elijahbenizzy
force-pushed
the
spawn-applications
branch
7 times, most recently
from
dadd91b
to
3c619fe
Compare
elijahbenizzy
changed the title
elijahbenizzy
force-pushed
the
spawn-applications
branch
from
3c619fe
to
e753966
Compare
elijahbenizzy
commented
Jun 1, 2024
| @@ -42,6 +43,9 @@ | |||
| from burr.lifecycle.base import LifecycleAdapter | |||
| from burr.lifecycle.internal import LifecycleAdapterSet | |||
|
|
|||
| if TYPE_CHECKING: | |||
There was a problem hiding this comment.
TODO -- double-check that this is needed
There was a problem hiding this comment.
I'll remove it later but this is OK for now. The other one we do an in-line import, but this is for type-checking
| @@ -1640,7 +1640,7 @@ | |||
| "name": "python", | |||
| "nbconvert_exporter": "python", | |||
| "pygments_lexer": "ipython3", | |||
| "version": "3.10.4" | |||
| "version": "3.11.6" | |||
There was a problem hiding this comment.
TODO -- change this back
notebook.ipynb
Outdated
elijahbenizzy
force-pushed
the
spawn-applications
branch
2 times, most recently
from
e1bca8b
to
1148692
Compare
A node can now query for application context by setting an input as __context -- this is of type ApplicationContext. This will allow forking (+ any other information we may need from inside the node). This is one of two __ variables (the other being tracer). The dependency factory is a bit in flux but the way these are constructed is not yet public-facing (we cannot arbitrarily add global injectors), so we can change it. This also fixes a bug in which dependency factories were not allowed to be optional/have defaults. This enables the user to build out a function that can be run outside the app (with a null context)..
This enables an application to specify the app that spawned it.
This enables us to track from child app the parents that spawned it
This does a little trickiness with the local tracker, but will allow the UI to display bidirectional links for forks/spawns.
This allows us to expand/focus on children in the app list. This also hides the partition key if it doesn't exist See #211
This adds the proper UI component + fixes logging/server to log correctly when spawning.
This is potentially backwards compatible, but people should really not be doing this -- in standard python convention (and burr, specifically), these are reserved for internal/special cases.
This way we can just run tests locally
Example + concepts doc
elijahbenizzy
force-pushed
the
spawn-applications
branch
from
1148692
to
fa9ec33
Compare
|
Killing this on in favor of the mega-one (easier to iterate on): #225 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows forking/parallelism. Part (1) of this: #52. In this PR we allow the user to do their own.
See #52
Changes
__contextinput for nodes to declare__contextto be nullableTODO:
How I tested this
Notes
Checklist