Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds GraphDB Conversational Agent example #222

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Jun 1, 2024

With help from the FalkorDB folks we added a GraphDB example to Burr.

This uses Hamilton to ingest and push data to FalkorDB that you run locally in a docker container. Then you
can run a Burr application to run the conversational agent.

I decided to add to the conversational agent directory because that seems like the more logical place to curate conversational agent examples.

So I moved the original example to simple_example and updated links accordingly. As long as we didn't link directly to the notebook but the repository example we should be good.

Changes

  • examples/conversational_rag

How I tested this

  • Locally

Notes

  • Doesn't work in collab because you need to talk to the DB

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

With help from the FalkorDB folks we added a GraphDB
example to Burr.

This uses Hamilton to ingest and push data to FalkorDB that
you run locally in a docker container. Then you
can run a Burr application to run the conversational agent.

I decided to add to the conversational agent directory
because that seems like the more logical place to curate
conversational agent examples.

So I moved the original example to simple_example and updated
links accordingly. As long as we didn't link directly to the notebook
but the repository example we should be good.
Instead just put conversational-rag on the filter list.

We should have a directive in the directory or something.
This assumes a flat file structure, but I think nested dirs
make more sense for curation...
Copy link
Contributor

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skrawcz skrawcz merged commit 0c96474 into main Jun 3, 2024
11 checks passed
@skrawcz skrawcz deleted the add_graph_db_example branch June 3, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants