Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Open Source #27

Closed
HamiltonRepoMigrationBot opened this issue Feb 23, 2023 · 2 comments
Closed

[CLOSED] Open Source #27

HamiltonRepoMigrationBot opened this issue Feb 23, 2023 · 2 comments

Comments

@HamiltonRepoMigrationBot
Copy link
Collaborator

Issue by skrawcz
Thursday May 13, 2021 at 03:23 GMT
Originally opened as stitchfix/hamilton#8


This PR does the following:

  1. Adds/rearranges documentation to make it easy for someone to hit the github page and know what to do to get started.
  2. Adds a license - Apache 2.0
  3. Scrubs the documentation of obvious things we wouldn't want to mention. I leave in some variable names because I think they are not leaking anything.

I'll squash merge this PR.


skrawcz included the following code: https://github.com/stitchfix/hamilton/pull/8/commits

@HamiltonRepoMigrationBot
Copy link
Collaborator Author

Comment by danfisher-sf
Wednesday Jul 28, 2021 at 14:57 GMT


This is so exciting!

@HamiltonRepoMigrationBot
Copy link
Collaborator Author

Comment by danfisher-sf
Wednesday Jul 28, 2021 at 15:09 GMT


i think you've scrubbed well and I'm not anxious about anything that's still in the markdowns, though, it may be worth adding a comment to the readme somewhere that states all of the code examples are just for illustration and do not reflect anything we are doing internally. just to cover ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants