Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Adds message about discord channel for help #7

Closed
12 tasks done
HamiltonRepoMigrationBot opened this issue Feb 23, 2023 · 0 comments
Closed
12 tasks done

Comments

@HamiltonRepoMigrationBot
Copy link
Collaborator

Issue by skrawcz
Saturday Mar 26, 2022 at 00:07 GMT
Originally opened as stitchfix/hamilton#100


Users should not be afraid to ask for help. This is a simple
catch all exceptions, log a message about discord, and raise.

Hopefully people have logging setup to see it, otherwise they
won't...

[Short description explaining the high-level reason for the pull request]

Changes

  • try excepts constructor and execute methods in driver

Testing

  1. Locally. E.g. output was:
-------------------------------------------------------------------
Oh no an error! Need help with Hamilton?
Join our discord and ask for help! https://discord.gg/wCqxqBqn73
-------------------------------------------------------------------

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

skrawcz included the following code: https://github.com/stitchfix/hamilton/pull/100/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants