You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Users should not be afraid to ask for help. This is a simple
catch all exceptions, log a message about discord, and raise.
Hopefully people have logging setup to see it, otherwise they
won't...
[Short description explaining the high-level reason for the pull request]
Changes
try excepts constructor and execute methods in driver
Testing
Locally. E.g. output was:
-------------------------------------------------------------------
Oh no an error! Need help with Hamilton?
Join our discord and ask for help! https://discord.gg/wCqxqBqn73
-------------------------------------------------------------------
Notes
Checklist
PR has an informative and human-readable title (this will be pulled into the release notes)
Changes are limited to a single goal (no scope creep)
Code can be automatically merged (no conflicts)
Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
Passes all existing automated tests
Any change in functionality is tested
New functions are documented (with a description, list of inputs, and expected output)
Placeholder code is flagged / future TODOs are captured in comments
Project documentation has been updated if adding/changing functionality.
Issue by skrawcz
Saturday Mar 26, 2022 at 00:07 GMT
Originally opened as stitchfix/hamilton#100
Users should not be afraid to ask for help. This is a simple
catch all exceptions, log a message about discord, and raise.
Hopefully people have logging setup to see it, otherwise they
won't...
[Short description explaining the high-level reason for the pull request]
Changes
Testing
Notes
Checklist
Testing checklist
Python - local testing
skrawcz included the following code: https://github.com/stitchfix/hamilton/pull/100/commits
The text was updated successfully, but these errors were encountered: