Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Adds message about discord channel for help #100

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Mar 26, 2022

Users should not be afraid to ask for help. This is a simple
catch all exceptions, log a message about discord, and raise.

Hopefully people have logging setup to see it, otherwise they
won't...

[Short description explaining the high-level reason for the pull request]

Changes

  • try excepts constructor and execute methods in driver

Testing

  1. Locally. E.g. output was:
-------------------------------------------------------------------
Oh no an error! Need help with Hamilton?
Join our discord and ask for help! https://discord.gg/wCqxqBqn73
-------------------------------------------------------------------

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

@skrawcz skrawcz force-pushed the add_error_message branch 2 times, most recently from 9205ba0 to afd7005 Compare March 26, 2022 00:28
Users should not be afraid to ask for help. This is a simple
catch all exceptions, log a message about discord, and raise.

Hopefully people have logging setup to see it, otherwise they
won't...

Message will look like this in people's output:
-------------------------------------------------------------------
Oh no an error! Need help with Hamilton?
Join our discord and ask for help! https://discord.gg/wCqxqBqn73
-------------------------------------------------------------------
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants