Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] remove duplicate functools import #8

Closed
8 of 12 tasks
HamiltonRepoMigrationBot opened this issue Feb 23, 2023 · 1 comment
Closed
8 of 12 tasks

[CLOSED] remove duplicate functools import #8

HamiltonRepoMigrationBot opened this issue Feb 23, 2023 · 1 comment

Comments

@HamiltonRepoMigrationBot
Copy link
Collaborator

Issue by jameslamb
Sunday Mar 27, 2022 at 20:40 GMT
Originally opened as stitchfix/hamilton#101

functools is imported twice in function_modifiers.py.

https://github.com/stitchfix/hamilton/blob/49f11ede9a79478f31b8ded2673ec0f977033562/hamilton/function_modifiers.py#L1-L2

This PR proposes removing one of them.

Changes

  • removes duplicate import of functools in hamilton.function_modifiers

Testing

None

Notes

None

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

jameslamb included the following code: https://github.com/stitchfix/hamilton/pull/101/commits
@HamiltonRepoMigrationBot
Copy link
Collaborator Author

Comment by elijahbenizzy
Tuesday Mar 29, 2022 at 02:01 GMT

Oi great find (as always!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elijahbenizzy @HamiltonRepoMigrationBot