Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

remove duplicate functools import #101

Merged
merged 1 commit into from
Mar 30, 2022
Merged

remove duplicate functools import #101

merged 1 commit into from
Mar 30, 2022

Conversation

jameslamb
Copy link
Contributor

functools is imported twice in function_modifiers.py.

import functools
import functools

This PR proposes removing one of them.

Changes

  • removes duplicate import of functools in hamilton.function_modifiers

Testing

None

Notes

None

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

@elijahbenizzy
Copy link
Collaborator

Oi great find (as always!)

@elijahbenizzy elijahbenizzy self-requested a review March 29, 2022 02:01
@elijahbenizzy elijahbenizzy merged commit d74bee7 into stitchfix:main Mar 30, 2022
@jameslamb jameslamb deleted the duplicate-import branch March 30, 2022 22:31
gitbook-com bot pushed a commit that referenced this pull request Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants