Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polars JSON reader/writer #418

Closed
Tracked by #410
skrawcz opened this issue Oct 2, 2023 · 4 comments
Closed
Tracked by #410

Polars JSON reader/writer #418

skrawcz opened this issue Oct 2, 2023 · 4 comments
Assignees

Comments

@skrawcz
Copy link
Collaborator

skrawcz commented Oct 2, 2023

Implement https://pola-rs.github.io/polars/py-polars/html/reference/io.html#json as a data saver/loader.

  1. It should go into polars_extensions.py, one class for the writer, on class for the reader, e.g. much like how the polars csv reader and writer are structured.
  2. There should be requisite tests to exercise the functionality. We can do one test that writes & then reads it's own output.
  3. Then an example should be added to a new directory called materialization under example/polars. It should mirror the pandas materialization example in structure.
  4. If there's an issue with type hints, let me know and we can chat through it.
@skrawcz skrawcz changed the title JSON Polars JSON reader/writer Oct 2, 2023
@swapdewalkar
Copy link
Contributor

I am taking this up

@TanyaKansal
Copy link

Is this issue open? Can I take it up?

@swapdewalkar
Copy link
Contributor

@TanyaKansal I am already working on this. check #410
Some version other are open.

@skrawcz
Copy link
Collaborator Author

skrawcz commented Oct 8, 2023

merged!

@skrawcz skrawcz closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants