Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polaris JSON Read Writer, Unit Test, Materilization. #440

Merged
merged 6 commits into from
Oct 8, 2023

Conversation

swapdewalkar
Copy link
Contributor

@swapdewalkar swapdewalkar commented Oct 5, 2023

--- PR TEMPLATE INSTRUCTIONS (1) ---
PR is regarding issue
Looking to submit a Hamilton Dataflow to the sf-hamilton-contrib module? If so go the the Preview tab and select the appropriate sub-template:

Else, if not, please remove this block of text.

--- PR TEMPLATE INSTRUCTIONS (2) ---

Polars JSON read/write

Changes

Polaris JSON Read Writer, Unit Test, materializations

How I tested this

unit test and materializations

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question on the import -- otherwise looking good thanks!

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. Will add my minor adjustment, and will merge. Thanks!

hamilton/plugins/polars_extensions.py Outdated Show resolved Hide resolved
We should always have file passed because it does not make sense to return a string value instead of writing to file here.
@skrawcz skrawcz merged commit 20c683f into DAGWorks-Inc:main Oct 8, 2023
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants