Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the original function pointer to node/variable objects #165

Merged
merged 1 commit into from May 5, 2023
Merged

Adds the original function pointer to node/variable objects #165

merged 1 commit into from May 5, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

Before we had no way of knowing which nodes were generated by which functions. This adds the capability. Each variable now points to the function that generated it.

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy
Adds the original function pointer to node/variable objects
8c10d77 
Before we had no way of knowing which nodes were generated by which
functions. This adds the capability. Each variable now points to the
functions that generated it.

Note this is a tuple of functions as multiple functions could have
generated it (in the case of a subdag). The order of these will always
have the lowest level function first, and will likely correspond to
namespaces, in reverse (although this contract isn't ironed in yet).
@elijahbenizzy elijahbenizzy merged commit 415f09e into main May 5, 2023
18 checks passed
@elijahbenizzy elijahbenizzy deleted the add-fn-pointer branch May 5, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elijahbenizzy @skrawcz