Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Pandas JSON data loaders #346

Merged
merged 21 commits into from
Sep 14, 2023

Conversation

bryangalindo
Copy link
Contributor

@bryangalindo bryangalindo commented Sep 13, 2023

This change introduces an extension of the Pandas read_json method found (here) and the Pandas to_json method found (here).

Changes

  • hamilton/plugins/pandas_extensions.py
  • tests/plugins/test_pandas_extensions.py

How I tested this

  • Successfully ran unit tests for py3.11 locally using the following command in the root directory: pytest tests/
  • Successfully ran unit tests for py3.7-3.10 using docker run command found here.

Notes

N/A

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@bryangalindo bryangalindo changed the title Adds pandas json data loaders Adds Pandas JSON data loaders Sep 13, 2023
@bryangalindo bryangalindo marked this pull request as ready for review September 13, 2023 02:59
@skrawcz skrawcz merged commit dfe9277 into DAGWorks-Inc:main Sep 14, 2023
1 check passed
@bryangalindo bryangalindo deleted the adds-pandas-json-data-loaders branch September 14, 2023 14:25
@skrawcz skrawcz mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants