Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Pandas DF SQL reader and writer #353

Merged
merged 13 commits into from
Sep 17, 2023

Conversation

bryangalindo
Copy link
Contributor

@bryangalindo bryangalindo commented Sep 16, 2023

This change introduces an extension of the Pandas read_sql method found (here) and the Pandas to_sql method found (here).

Changes

  • examples/pandas/materialization/my_script.py
  • examples/pandas/materialization/notebook.ipynb
  • examples/pandas/materialization/requirements.txt
  • hamilton/io/utils.py
  • hamilton/plugins/pandas_extensions.py
  • requirements-test.txt
  • tests/io/test_utils.py
  • tests/plugins/test_pandas_extensions.py
  • tests/resources/data/test.db

How I tested this

  • Confirmed unit tests for py3.11 passed; locally ran the following command in the root directory: pytest tests/
  • Confirmed circleci py37-py3.11 tests all passed.

Notes

N/A

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@bryangalindo

This comment was marked as resolved.

hamilton/io/utils.py Outdated Show resolved Hide resolved
@bryangalindo

This comment was marked as resolved.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments & requests. If you could modify the example and add that commit here too that would be great please :)

hamilton/io/utils.py Outdated Show resolved Hide resolved
hamilton/plugins/pandas_extensions.py Show resolved Hide resolved
hamilton/plugins/pandas_extensions.py Show resolved Hide resolved
hamilton/io/utils.py Outdated Show resolved Hide resolved
hamilton/io/utils.py Outdated Show resolved Hide resolved
hamilton/io/utils.py Show resolved Hide resolved
@bryangalindo bryangalindo marked this pull request as ready for review September 17, 2023 04:49
@skrawcz skrawcz merged commit 8e12e7a into DAGWorks-Inc:main Sep 17, 2023
20 checks passed
@bryangalindo bryangalindo deleted the adds-pandas-sql-reader-writer branch September 18, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants