Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polars parquet #417 #425

Merged
merged 11 commits into from
Oct 4, 2023
Merged

Conversation

swapdewalkar
Copy link
Contributor

@swapdewalkar swapdewalkar commented Oct 3, 2023

Polars Parquet Data Saver /Loader.
Implement https://pola-rs.github.io/polars/py-polars/html/reference/io.html#parquet as a data saver/loader.

Changes

  • Parquet Wrapper
  • Unit tests
  • Materialize Example

How I tested this

I ran unit tests.

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@swapdewalkar swapdewalkar changed the title Polars parquet Polars parquet #417 Oct 3, 2023
@skrawcz
Copy link
Collaborator

skrawcz commented Oct 3, 2023

storage_options: dict[str, Any] = None

E TypeError: 'type' object is not subscriptable

For python 3.7 -- dict[str, Any] isn't valid. Instead it should be Dict[str, Any].

@swapdewalkar
Copy link
Contributor Author

For Issue #417

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

examples/polars/materialization/notebook.ipynb Outdated Show resolved Hide resolved
examples/polars/materialization/my_script.py Outdated Show resolved Hide resolved
@swapdewalkar
Copy link
Contributor Author

@skrawcz update take a look once!

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- just need to remove references to things we don't need yet.

examples/polars/materialization/my_script.py Outdated Show resolved Hide resolved
examples/polars/materialization/my_script.py Outdated Show resolved Hide resolved
examples/polars/materialization/my_script.py Outdated Show resolved Hide resolved
examples/polars/materialization/notebook.ipynb Outdated Show resolved Hide resolved
examples/polars/materialization/notebook.ipynb Outdated Show resolved Hide resolved
examples/polars/materialization/notebook.ipynb Outdated Show resolved Hide resolved
examples/polars/materialization/requirements.txt Outdated Show resolved Hide resolved
Removing code that is not required for the example.
@skrawcz skrawcz merged commit 48d174b into DAGWorks-Inc:main Oct 4, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants