Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes inconsistency in new builder API #430

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Oct 3, 2023

The default should be a dictionary adapter. In the case that you were not using the "V2" functionality there was a typo and it would not set the adapter to the dictionary one, instead passing in None, and therefore defaulting to the dataframe adapter.

Changes

  • driver.py
  • test_hamilton_driver.py

How I tested this

  • locally ran unit tests

Notes

  • AFAICT nothing assumed this bug as a feature.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

The default should be a dictionary adapter. In the case that
you were not using the "V2" functionality there was a typo
and it would not set the adapter to the dictionary one, instead
passing in None, and therefore defaulting to the dataframe adapter.
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skrawcz skrawcz merged commit 100e765 into main Oct 3, 2023
21 checks passed
@skrawcz skrawcz deleted the fix_default_builder_adapter branch October 3, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants