Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves data loader experience by allowing non-source/value kwargs #434

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Oct 4, 2023

Before we would only allow source/value kwargs for @load_from/@save_to, which would silently drop any non-source/value kwargs. Now we can use non-source/value kwargs, and they'll be interpreted as value kwargs.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy changed the title Improves data loader eperience by allowing non-source/value kwargs Improves data loader experience by allowing non-source/value kwargs Oct 4, 2023
Before we would only allow source/value kwargs for @load_from/@save_to,
which would silently drop any non-source/value kwargs. Now we can use
non-source/value kwargs, and they'll be interpreted as value kwargs.
@elijahbenizzy elijahbenizzy merged commit 7e0b365 into main Oct 4, 2023
21 checks passed
@elijahbenizzy elijahbenizzy deleted the materializer-fix branch October 4, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants