Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter notebook can autocomplete materializers #438

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Jupyter notebook can autocomplete materializers #438

merged 2 commits into from
Oct 5, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Oct 4, 2023 •
edited
Loading

Allows auto-completion of materializers on jupyter notebook.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy changed the title WIP Jupyter notebook can autocomplete materializers Oct 5, 2023
@elijahbenizzy elijahbenizzy force-pushed the autocomplete-materializers branch 2 times, most recently from 995f6e2 to 9e57f3f Compare October 5, 2023 04:22
@elijahbenizzy
Adds ability for jupyter notebook to autocomplete materializers
5fef147 
This does the following:
1. Switches materializer_meta__ to dynamically register materializers,
   rather than getting them through attributes
2. Adds signatures to the registered mateiralizers
3. Replaces the kwargs in those signatures with the union of all
   possible parameters

This allows auto-completion on jupyter notebook. Note this does not work
in pycharm.
@elijahbenizzy
Fixes return value of has_cycles
1643148 
This was returning False -- it should return an empty list.
@elijahbenizzy elijahbenizzy merged commit 304b26c into main Oct 5, 2023
21 checks passed
@elijahbenizzy elijahbenizzy deleted the autocomplete-materializers branch October 5, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees

@skrawcz skrawcz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elijahbenizzy @skrawcz