Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds input validation to materialize execution path #445

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Oct 6, 2023

It was not doing what execute does, and validating inputs before execution. This fixes that, and adds a basic test for it.

Changes

  • driver.py
  • test_hamilton_driver.py

How I tested this

  • locally
  • via unit tests

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

It was not doing what execute does, and validating inputs
before execution. This fixes that, and adds a basic test for it.
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skrawcz skrawcz merged commit bc9df3d into main Oct 6, 2023
21 checks passed
@skrawcz skrawcz deleted the validate_inputs_in_materialize branch October 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants