Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Plotly materializer #496

Merged
merged 3 commits into from
Nov 9, 2023
Merged

added Plotly materializer #496

merged 3 commits into from
Nov 9, 2023

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Oct 24, 2023

--- PR TEMPLATE INSTRUCTIONS (2) ---
Added Plotly materializer supports both static formats (JPG, PNG, SVG, etc.) and interactive format (HTML + JS)

Changes

Added PlotlyInteractiveSaver and PlotlyStaticSaver along with tests.

How I tested this

Added a test to check files were properly written for each DataSaver. I manually checked that the written files could be properly opened

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@DAGWorks-Inc DAGWorks-Inc deleted a comment from sweep-ai bot Oct 30, 2023
@skrawcz
Copy link
Collaborator

skrawcz commented Nov 2, 2023

@zilto seems like 3.7/3.8 python syntax to fix up. Otherwise looks good.

@zilto zilto requested a review from skrawcz November 8, 2023 18:56
@skrawcz skrawcz merged commit e955740 into main Nov 9, 2023
21 checks passed
@skrawcz skrawcz deleted the feature/plotly-materializer branch November 9, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants