-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves Official to DAGWorks for contrib/hub #528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because that's who is maintaining it. I also tacked on refactoring the python hub docs code into jinja2 to enable more easily having conditional logic that is easier to maintain.
So that people can see an index. This is a quick way to get to this screen without really trying to customize docusaurus.
For the hub we don't want to have to bump the version in the docs. So removing specifying the version for now. Though we could build something to know what the version is that's more effort than I want to do at the moment.
So if someone does not have sf-hamilton-contrib installed, you could download a dataflow but not be able to import it, because they have a dependency on having a `hamilton.contrib` submodule. This sticks a placeholder in -- to enable things to work without installing sf-hamilton-contrib. The assumption is that it will get clobbered by installed `sf-hamilton-contrib`, and everything should continue to work. This also updates the telemetry code to handle this case, and to parse the relevant details from the file path. I have tested that things work for old and new paths. What I haven't extensively tested is the installation order.
For some reason this was breaking for me, and this fixed it.
skrawcz
force-pushed
the
contrib_changes
branch
from
November 11, 2023 00:37
b522f6e
to
4e079c4
Compare
Not sure what pre-commit is complaining about:
|
This reverts commit 8288b7f.
This is pretty basic. But putting something up here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because that's who is maintaining it.
I also tacked on refactoring the python hub docs
code into jinja2 to enable more easily having
conditional logic that is easier to maintain.
Changes
How I tested this
Notes
Checklist