Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves Official to DAGWorks for contrib/hub #528

Merged
merged 11 commits into from
Nov 11, 2023
Merged

Moves Official to DAGWorks for contrib/hub #528

merged 11 commits into from
Nov 11, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Nov 10, 2023

Because that's who is maintaining it.

I also tacked on refactoring the python hub docs
code into jinja2 to enable more easily having
conditional logic that is easier to maintain.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Because that's who is maintaining it.

I also tacked on refactoring the python hub docs
code into jinja2 to enable more easily having
conditional logic that is easier to maintain.
So that people can see an index.

This is a quick way to get to this screen
without really trying to customize docusaurus.
For the hub we don't want to have to bump the version
in the docs. So removing specifying the version for now.
Though we could build something to know what the version
is that's more effort than I want to do at the moment.
So if someone does not have sf-hamilton-contrib installed, you could
download a dataflow but not be able to import it, because they
have a dependency on having a `hamilton.contrib` submodule. This sticks
a placeholder in -- to enable things to work without installing sf-hamilton-contrib.
The assumption is that it will get clobbered by installed `sf-hamilton-contrib`,
and everything should continue to work.

This also updates the telemetry code to handle this case, and to parse
the relevant details from the file path. I have tested that things work
for old and new paths.

What I haven't extensively tested is the installation order.
For some reason this was breaking for me,
and this fixed it.
@skrawcz
Copy link
Collaborator Author

skrawcz commented Nov 11, 2023

Not sure what pre-commit is complaining about:

black....................................................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
fix requirements.txt.....................................................Passed
check python ast.........................................................Passed
isort....................................................................Passed
flake8...................................................................Passed```

@skrawcz skrawcz marked this pull request as ready for review November 11, 2023 01:08
This is pretty basic. But putting something up here.
@skrawcz skrawcz merged commit d9f7a44 into main Nov 11, 2023
24 checks passed
@skrawcz skrawcz deleted the contrib_changes branch November 11, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant