Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds comparisons to langchain #672

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Adds comparisons to langchain #672

merged 2 commits into from
Feb 1, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jan 31, 2024

This I think shows a few things well.
Langchain is obviously smaller, but
it's a lot less flexible and hides a lot.

Changes

  • adds to docs
  • adds to examples

How I tested this

  • ran things locally

Notes

  • I had to update configuration for pre-commit because we need the code to be skinny to display well side by side.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This adds to the docs so that we can more easily and clearly
show people side by side comparison of code. Also adds
a section to the LLM Workflows folder to make this comparison
accessible there.
This will exclude the code snippets from being formatted
because we need them to be skinny.

This also upgrades pre-commit hooks and fixes any
issues arizing from the new updates.
@skrawcz skrawcz merged commit 3ea0068 into main Feb 1, 2024
4 of 24 checks passed
@skrawcz skrawcz deleted the add_lcel_comparison branch February 1, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant