Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates jupyter magic to display in databricks #709

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Feb 22, 2024

Databricks doesn’t automatically render. So we
have to render it ourselves. I decided on HTML
over Image for no good reason really.

This should also handle errors if graphviz isn’t installed and the visualization extra isn’t installed.

Changes

  • jupyter_magic.py

How I tested this

  • via databricks notebook
  • locally via regular notebook

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Databricks doesn’t automatically render. So we
have to render it ourselves. I decided on HTML
over Image for no good reason really.

This should also handle errors if graphviz isn’t installed
and the visualization extra isn’t installed.
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will it work without jupyter_magic as well? E.G. can we get the return of a graphviz object to display in a databricks notebook?

@skrawcz skrawcz merged commit 8a00d17 into main Feb 23, 2024
22 checks passed
@skrawcz skrawcz deleted the databricks_magic branch February 23, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants