Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in README #839

Merged
merged 1 commit into from Apr 23, 2024
Merged

Conversation

adayNU
Copy link
Contributor

@adayNU adayNU commented Apr 23, 2024

It seems like because a few links lack a protocol, GitHub is treating them as Relative Links.

Changes

Just cosmetic fixes to the README.

How I tested this

Previewing my changes in the rich diff shows the links are now correct.

Notes

N/A

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

It seems like because a few links lack a protocol, GitHub is treating them as [Relative Links](https://github.blog/2013-01-31-relative-links-in-markup-files/).
@zilto
Copy link
Collaborator

zilto commented Apr 23, 2024

Good catch! Thank you for the Pull request

@zilto zilto merged commit a21be46 into DAGWorks-Inc:main Apr 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants