-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter magics v2 #846
Jupyter magics v2 #846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure the compatibility case. It's backwards-incompatible, right? If so, are we OK with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah so I like some of the changes, but not others.
For example the departure from having to provide valid driver builder code is a concern because I think that makes the experience confusing from regular Hamilton. It's also not clear where the modules comes from that go into the driver. E.g. What if I have multiple modules and want several different drivers?
Let's chat about it some more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we link to this file from the blogs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will create a new example.ipynb
based on the recent RAG PR once we settle on the Jupyter V2 API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah so out of principal we don't push backwards incompatible changes.
Options:
- rename the magic.
- live with
-m
... - have a really good error message and suggest the fix and apologize and ask for forgiveness... (is this possible to do well?)
From chatting:
|
|
||
```python | ||
%%cell_to_module -m MODULE_NAME # more args |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have output of ?cell_to_module
instead.
Closing in favor of #917 |
Please read the tutorial notebook for all details.
TODO
%%execute
cell magicChanges
jupyter_extensions
to be consistent with other extensions? Nothing stops this file from containing other things than "magics". This matters because it's what users need to import via%load_ext hamilton.plugins.jupyter_extensions
whereas "magic" is probably an odd term for most peopleHow I tested this
rebuild_driver()
Notes
sys.modules
? Maybe it's just VSCode + Pylance LSP disliking magic code cells. Don't knowChecklist