Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes spark example module name #862

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Changes spark example module name #862

merged 1 commit into from
Apr 29, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Apr 29, 2024

To make it more intuitive and less confusing with the name clash with @with_columns.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

To make it more intuitive and less confusing with the
name clash with `@with_columns`.
@skrawcz skrawcz merged commit 3380cbe into main Apr 29, 2024
0 of 5 checks passed
@skrawcz skrawcz deleted the fix_example_naming branch April 29, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant