refs LibraryOfCongress#121 - only use as many threads as CPUs

DANS-KNAW · Feb 20, 2019 · 3cc8f2f · 3cc8f2f
1 parent 1fce68f
commit 3cc8f2f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/gov/loc/repository/bagit/verify/BagVerifier.java b/src/main/java/gov/loc/repository/bagit/verify/BagVerifier.java
@@ -45,7 +45,7 @@ public final class BagVerifier implements AutoCloseable{
    * {@link StandardBagitAlgorithmNameToSupportedAlgorithmMapping}
    */
   public BagVerifier(){
-    this(Executors.newCachedThreadPool(), new StandardBagitAlgorithmNameToSupportedAlgorithmMapping());
+    this(Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()), new StandardBagitAlgorithmNameToSupportedAlgorithmMapping());
   }
 
   /**
@@ -54,7 +54,7 @@ public BagVerifier(){
    * @param nameMapping the mapping between BagIt algorithm name and the java supported algorithm
    */
   public BagVerifier(final BagitAlgorithmNameToSupportedAlgorithmMapping nameMapping){
-    this(Executors.newCachedThreadPool(), nameMapping);
+    this(Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()), nameMapping);
   }
 
   /**

diff --git a/src/main/java/gov/loc/repository/bagit/verify/ManifestVerifier.java b/src/main/java/gov/loc/repository/bagit/verify/ManifestVerifier.java
@@ -43,7 +43,7 @@ public class ManifestVerifier implements AutoCloseable{
    * {@link StandardBagitAlgorithmNameToSupportedAlgorithmMapping} mapping
    */
   public ManifestVerifier(){
-    this(new StandardBagitAlgorithmNameToSupportedAlgorithmMapping(), Executors.newCachedThreadPool());
+    this(new StandardBagitAlgorithmNameToSupportedAlgorithmMapping(), Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()));
   }
 
   /**
@@ -52,7 +52,7 @@ public ManifestVerifier(){
    * @param nameMapping the mapping between BagIt algorithm name and the java supported algorithm
    */
   public ManifestVerifier(final BagitAlgorithmNameToSupportedAlgorithmMapping nameMapping) {
-    this(nameMapping, Executors.newCachedThreadPool());
+    this(nameMapping, Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()));
   }
 
   /**

diff --git a/src/test/java/gov/loc/repository/bagit/verify/CheckIfFileExistsTaskTest.java b/src/test/java/gov/loc/repository/bagit/verify/CheckIfFileExistsTaskTest.java
@@ -17,7 +17,7 @@ public class CheckIfFileExistsTaskTest extends TempFolderTest {
 
   @Test
   public void testNormalizedFileExists() throws Exception{
-    ExecutorService executor = Executors.newCachedThreadPool();
+    ExecutorService executor = Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors());
     CountDownLatch latch = new CountDownLatch(1);
     Set<Path> missingFiles = new ConcurrentSkipListSet<>();
     String filename = "Núñez.txt";