Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.0 warning #6

Merged
merged 1 commit into from Oct 2, 2020
Merged

Fix PHP 8.0 warning #6

merged 1 commit into from Oct 2, 2020

Conversation

ausi
Copy link
Contributor

@ausi ausi commented Sep 10, 2020

Fixes #5

@ausi
Fix PHP 8.0 warning
61861aa 
PHP Warning:  Private methods cannot be final as they are never overridden by other classes
This was referenced Sep 10, 2020
Closed
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 61861aa on ausi:fix/php-8-compat into 6ccc0d7 on DASPRiD:master.

@williamdes

This comment has been minimized.

Sign in to view
@DASPRiD DASPRiD merged commit 5abf82f into DASPRiD:master Oct 2, 2020
@ausi ausi deleted the fix/php-8-compat branch October 3, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PHP 8.0] Private methods cannot be final as they are never overridden by other classes
4 participants
@ausi @coveralls @williamdes @DASPRiD