-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queries may not be using ISO SQL where possible (W) #4
Comments
Sean Murthy (smurthys) |
Steven Rollo (srrollo) |
Need to carefully review all data types (especially Also, every non-standard use should be clearly documented in code. |
|
Here is a list of non-standard types used and some thoughts on replacing them: prepareClassDB.sql prepareUserLogging.sql metaFunctions.sql |
With I agree we leave the schema of
|
Yes, |
In Using |
One downside to Another place where |
All instances identified as of 6/23 have been fixed Small formatting fix in metaFunctions and prepareUserLogging
I decided to go with the single function solution in 8479bc8. So far, I have only updated metaFunctions.sql. I will edit |
To keep the data types consistent, we should update the userName parameters in prepareClassDB and prepareClassServer to VARCHAR(63) instead of VARCHAR(50), in order to match the new changed types in PR #55. |
Some more instances are located here
|
These instances were addressed in adf6656. |
Generally, Make sure queries use ISO SQL as much as possible. This includes using ISO standard data types, statements, and schemas such as
Information_Schema
(see #1).The text was updated successfully, but these errors were encountered: