Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nit] Migrate to docker compose v2 #53

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

stefafafan
Copy link
Collaborator

ref. https://docs.docker.com/compose/migrate/

When running the tests locally, I get messages like this.

$ make test
WARNING: Compose V1 is no longer supported and will be removed from Docker Desktop in an upcoming release. See https://docs.docker.com/go/compose-v1-eol/
mysql: [Warning] Using a password on the command line interface can be insecure.
WARNING: Compose V1 is no longer supported and will be removed from Docker Desktop in an upcoming release. See https://docs.docker.com/go/compose-v1-eol/
mysql: [Warning] Using a password on the command line interface can be insecure.
WARNING: Compose V1 is no longer supported and will be removed from Docker Desktop in an upcoming release. See https://docs.docker.com/go/compose-v1-eol/
mysql: [Warning] Using a password on the command line interface can be insecure.
WARNING: Compose V1 is no longer supported and will be removed from Docker Desktop in an upcoming release. See https://docs.docker.com/go/compose-v1-eol/
...

This is annoying, so I replaced docker-compose with docker compose. Now it is a lot simpler. This docker-compose file is only used for testing purposes so should not have any affect to users using go-txdb.

$ make test
mysql: [Warning] Using a password on the command line interface can be insecure.
mysql: [Warning] Using a password on the command line interface can be insecure.
mysql: [Warning] Using a password on the command line interface can be insecure.
mysql: [Warning] Using a password on the command line interface can be insecure.
DROP DATABASE
CREATE DATABASE
CREATE TABLE
INSERT 0 3
Opening db...
Opening db...
[nit] migrate to docker compose v2
PASS
ok  	github.com/DATA-DOG/go-txdb	0.439s

@stefafafan stefafafan self-assigned this Jun 7, 2023
@stefafafan stefafafan requested a review from Yiling-J June 7, 2023 14:07
@stefafafan stefafafan merged commit 5bd9aad into master Jun 7, 2023
8 checks passed
@stefafafan stefafafan deleted the docker-compose-v2 branch June 7, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants